[SPARK-53957][Geo][SQL] Support GEOGRAPHY and GEOMETRY in the SpatialReferenceSystemMapper #52667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
uros-db
commented
Oct 20, 2025
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
@mkaravel @szehon-ho Please review.
mkaravel
reviewed
Oct 24, 2025
...rc/main/scala/org/apache/spark/sql/internal/types/CartesianSpatialReferenceSystemMapper.java
Outdated
Show resolved
Hide resolved
...rc/main/scala/org/apache/spark/sql/internal/types/CartesianSpatialReferenceSystemMapper.java
Outdated
Show resolved
Hide resolved
...c/main/scala/org/apache/spark/sql/internal/types/GeographicSpatialReferenceSystemMapper.java
Outdated
Show resolved
Hide resolved
...c/main/scala/org/apache/spark/sql/internal/types/GeographicSpatialReferenceSystemMapper.java
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/internal/types/SpatialReferenceSystemCache.java
Outdated
Show resolved
Hide resolved
mkaravel
approved these changes
Oct 24, 2025
Contributor
mkaravel
left a comment
mkaravel
left a comment
There was a problem hiding this comment.
Thank you for addressing the review comments.
LGTM.
Contributor
Author
|
@cloud-fan Please review. |
Contributor
Author
|
@cloud-fan This one should be good to go. |
cloud-fan
reviewed
Oct 28, 2025
sql/api/src/main/scala/org/apache/spark/sql/internal/util/SingletonBase.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Oct 29, 2025
...pi/src/main/scala/org/apache/spark/sql/internal/types/SpatialReferenceSystemInformation.java
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Oct 29, 2025
Contributor
|
thanks, merging to master! |
Yicong-Huang
pushed a commit
to Yicong-Huang/spark
that referenced
this pull request
Oct 30, 2025
…ReferenceSystemMapper ### What changes were proposed in this pull request? Extend the `SpatialReferenceSystemMapper` class to offer SRID <-> CRS mappings for both `GeographyType` and `GeometryType`. The `SpatialReferenceSystemMapper` class was introduced originally as part of: apache#52491. ### Why are the changes needed? Avoid manual checks for GEOGRAPHY type, and use the centralized SRS mapping logic. Also, this PR will make it easier to support additional SRID/CRS values for spatial types soon. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added new tests to: - `SpatialReferenceSystemMapperSuite` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52667 from uros-db/geo-srsMapper. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
zhengruifeng
pushed a commit
that referenced
this pull request
Oct 31, 2025
…n PySpark ### What changes were proposed in this pull request? Implement the Spatial Reference System Mapper classes to offer SRID <-> CRS mappings in PySpark, for both `GeographyType` and `GeometryType`. On JVM / Scala side, the `SpatialReferenceSystemMapper` class was introduced originally as part of: #52491, and then subsequently extended in: #52667. ### Why are the changes needed? Use centralized SRS mapping logic in PySpark, same as we currently do in Scala types. Also, this PR will make it easier to support additional SRID/CRS values for spatial types soon. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Updated tests in: - `test_geographytype` - `test_geometrytype` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52799 from uros-db/geo-srsMapper-python. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extend the
SpatialReferenceSystemMapperclass to offer SRID <-> CRS mappings for bothGeographyTypeandGeometryType.The
SpatialReferenceSystemMapperclass was introduced originally as part of: #52491.Why are the changes needed?
Avoid manual checks for GEOGRAPHY type, and use the centralized SRS mapping logic.
Also, this PR will make it easier to support additional SRID/CRS values for spatial types soon.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new tests to:
SpatialReferenceSystemMapperSuiteWas this patch authored or co-authored using generative AI tooling?
No.